Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min go runtime to be 1.23 and add godebug winsymlink=0 #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Dec 11, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This is in response to this thread
https://groups.google.com/g/container-storage-interface-community/c/btNUUr67OMA/m/DFk-N-dBAQAJ


golang 1.23 has made some significant changes to how Windows mount points are reported. We are still evaluating the impact, so until we fully understand what fixes we may need to make, CSI drivers and csi-proxy should either:

  1. Hold off on upgrading to golang 1.23 until we provide further guidance. This also means refraining from updating k8s.io/mount-utils to v0.32.0
  2. If upgrading to golang 1.23, add the "godebug winsymlink=0" flag to the go.mod file to disable these changes.

See kubernetes/kubernetes#129080 for more details.


Through #362 we used go 1.23 to build the binary so I think we should set a min go version and godebug winsymlink=0 in go.mod

Does this PR introduce a user-facing change?:

Set min go version to 1.23 and godebug winsymlink=0 in go.mod

/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 December 11, 2024 19:25
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants